Messages in this thread | | | Date | Wed, 23 Feb 2011 21:54:19 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH v3 1/2] PRUSS UIO driver support |
| |
On Wed, 23 Feb 2011, Sergei Shtylyov wrote: > Hello. > > On 23-02-2011 23:25, Thomas Gleixner wrote: > > > > + prussio_virt_addr = > > > + ioremap(regs_prussio->start, > > > + regs_prussio->end - regs_prussio->start + 1); > > > Either make those variable names shorter or do: > > > len = regs_prussio->end - regs_prussio->start + 1; > > Or even: > > len = resource_size(regs_prussio); > > > prussio_virt_addr = ioremap(regs_prussio->start, len);
Good point. Forgot about that one :)
Thanks,
tglx
| |