lkml.org 
[lkml]   [2011]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] PRUSS UIO driver support
On Wed, 23 Feb 2011, Sergei Shtylyov wrote:
> Hello.
>
> On 23-02-2011 23:25, Thomas Gleixner wrote:
>
> > > + prussio_virt_addr =
> > > + ioremap(regs_prussio->start,
> > > + regs_prussio->end - regs_prussio->start + 1);
>
> > Either make those variable names shorter or do:
>
> > len = regs_prussio->end - regs_prussio->start + 1;
>
> Or even:
>
> len = resource_size(regs_prussio);
>
> > prussio_virt_addr = ioremap(regs_prussio->start, len);

Good point. Forgot about that one :)

Thanks,

tglx


\
 
 \ /
  Last update: 2011-02-23 21:57    [W:0.113 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site