lkml.org 
[lkml]   [2011]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC tip/core/rcu 11/11] rcu: move TREE_RCU from softirq to kthread
On Wed, Feb 23, 2011 at 01:22:02PM -0600, Christoph Lameter wrote:
> On Wed, 23 Feb 2011, Paul E. McKenney wrote:
>
> > These do introduce redundant preempt_disable()/preempt_enable() calls, but
> > this is not on a fastpath, so should be OK, and the improved readability
> > is certainly nice. The read and the write do need to happen on the same
> > CPU, FWIW.
>
> this_cpu_xxx only use preempt_enable/disable() on platforms that do not
> support per cpu atomic instructions. On x86 no preempt enable/disable will
> be inserted.
>
> You can also use the __this_cpu_xxx operations which never add preempt
> disable/enable because they expect the caller to deal with preemption.

Those make a lot of sense in this case, as I need to use __get_cpu_var()
anyway.

Thank you for all the info!

Thanx, Paul


\
 
 \ /
  Last update: 2011-02-23 20:41    [W:7.337 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site