lkml.org 
[lkml]   [2011]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC tip/core/rcu 11/11] rcu: move TREE_RCU from softirq to kthread
From
Date
On Wed, 2011-02-23 at 09:02 -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> [...]
> > + for (cpu = rnp->grplo; cpu <= rnp->grphi; cpu++, mask <<= 1)
> > + if (mask & 01)
>
> Wow, octal notation! ;)

Heh

>
> Maybe we could consider 0x1 here.

Why even the conversion? mask & 1 should be good enough.

Perhaps 1UL to match the unsigned long.

-- Steve




\
 
 \ /
  Last update: 2011-02-23 15:45    [from the cache]
©2003-2011 Jasper Spaans