lkml.org 
[lkml]   [2011]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] staging: vme: fix bug in vme_register_bridge
On Wed, Feb 23, 2011 at 09:44:42AM +0000, Martyn Welch wrote:
> On 23/02/11 09:26, Manohar Vanga wrote:
> > Fix a bug in vme_register_bridge that results in an infinite loop in
> > the event that device_register fails.

[snip]

> > + /*
> > + * Ignore the failed device and unregister the rest.
> > + */
> > + i--;
> > while (i > -1) {
> > dev = &bridge->dev[i];
> > device_unregister(dev);
> > + i--;
> > }

Ah. I see you fixed the bug already. Good deal. Btw, no need to add
comments for the obvious stuff.

You still aren't CCing the right list, devel@driverdev.osuosl.org.
It's not enough for Martyn to sent it to us, because by that point
the patch has '> ' chars on every line.

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-02-23 13:27    [W:0.146 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site