Messages in this thread | | | From | Jeremy Kerr <> | Subject | Re: [PATCH 1/2] Add a common struct clk | Date | Wed, 23 Feb 2011 10:49:17 +0800 |
| |
Hi Uwe,
> > +static inline void clk_common_init(struct clk *clk) { } > > + > > +/* > > + * For !CONFIG_USE_COMMON_STRUCT_CLK, we don't enforce any atomicity > > + * requirements for clk_enable/clk_disable, so the prepare and unprepare > > + * functions are no-ops > > + */ > > +int clk_prepare(struct clk *clk) { return 0; } > > +void clk_unprepare(struct clk *clk) { } > > these should be static inline. Otherwise these functions end up in many > files and so provoke a build failure.
Ugh, brown paper bag time. Thanks for that, I'll update this patch.
Cheers,
Jeremy
| |