Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 22 Feb 2011 12:47:09 -0800 | Subject | Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions |
| |
On Tue, Feb 22, 2011 at 9:08 AM, Jesper Nilsson <jesper.nilsson@axis.com> wrote: > > That's probably just a legacy from when I combined the linkscripts > for the two architectures. If I remember correctly, RODATA brings > in RO_DATA_SECTION which in turn brings in __param and __modver > for both architectures. CRISv32 then duplicates the __param stuff > for some historical reason.
Hmm. This makes it sound like the patch should be to remove the __param thing rather than to add the _modver thing. And I can definitely confirm that cris seems to use RODATA, which brings in the RO_DATA_SECTION() thing with proper page alignment.
But:
> True, at least until I've made sure that there isn't any > underlying reason for CRISv32 to put __param in a different place... > > Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
I really am not going to apply a patch that likely just adds another redundant field to the linker scripts. So the ack I'm just ignoring,
But it would be good to get the "remove the legacy __param thing because it's already there from the asm-generic version" confirmed by testing, and not just looking at the source code.
Linus
| |