Messages in this thread | | | Date | Tue, 22 Feb 2011 14:47:25 -0500 | From | "John W. Linville" <> | Subject | Re: [PATCH] rt2x00: Use ops name instead of device name |
| |
On Tue, Feb 22, 2011 at 08:33:45PM +0100, Ivo Van Doorn wrote: > Hi, > > On Tue, Feb 22, 2011 at 2:44 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > > On Tue, 2011-02-22 at 13:34 +0000, Ben Hutchings wrote: > > > >> > 19: 73474106 0 IO-APIC-fasteoi ata_piix, uhci_hcd:usb6, 0000:05:01.0 > > > >> > rt2x00dev->irq = pci_dev->irq; > >> > - rt2x00dev->name = pci_name(pci_dev); > >> > + rt2x00dev->name = ops->name; > > > > > >> But then how can users distinguish the IRQs for multiple devices handled > >> by the same driver? (Probably unusual for WLAN devices, but still > >> possible.) > >> > >> I assume you can't use a net device name as there may be multiple net > >> devices per bus device? > > > > Honestly, I do not know this code well enough, but this patch seemed to > > solve the problem at hand. Hence I sent it out to the experts hoping > > they either take this patch or come up with a proper solution ;) > > > > In any case, just posting the pci address is not a pretty answer. > > I just checked the other wireless drivers, and they all seem to use > the modulename. So I guess your patch is correct. You can add my: > > Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
I completely missed this series -- please be sure to Cc: linux-wireless@vger.kernel.org if you resend, and/or resend the series directly to me?
Thanks!
John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |