lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 11/12] unicore32 machine related files: ps2 driver
Date
On Tuesday 22 February 2011, Guan Xuetao wrote:
> diff --git a/drivers/input/serio/i8042-unicore32io.h b/drivers/input/serio/i8042-unicore32io.h
> index 2cdd872..9350843 100644
> --- a/drivers/input/serio/i8042-unicore32io.h
> +++ b/drivers/input/serio/i8042-unicore32io.h
> @@ -29,11 +29,11 @@
> /*
> * Register numbers.
> */
> -#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND)
> -#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS)
> -#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA)
> +#define I8042_COMMAND_REG PS2_COMMAND
> +#define I8042_STATUS_REG PS2_STATUS
> +#define I8042_DATA_REG PS2_DATA

I wouldn't bother defining two sets of macros then. Either use PS2_COMMAND
in the driver, or define I8042_COMMAND_REG in the place where you currently
define PS2_COMMAND.

Aside from this, it looks good.

Arnd


\
 
 \ /
  Last update: 2011-02-22 18:15    [W:0.066 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site