lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/8] Fix interleaving for transparent hugepages
    On Tue, Feb 22, 2011 at 09:34:33AM -0600, Christoph Lameter wrote:
    >
    > On Mon, 21 Feb 2011, Andi Kleen wrote:
    >
    > > @@ -1830,7 +1830,7 @@ alloc_pages_vma(gfp_t gfp, int order, struct vm_area_struct *vma,
    > > if (unlikely(pol->mode == MPOL_INTERLEAVE)) {
    > > unsigned nid;
    > >
    > > - nid = interleave_nid(pol, vma, addr, PAGE_SHIFT);
    > > + nid = interleave_nid(pol, vma, addr, PAGE_SHIFT << order);
    >
    > Should be PAGE_SHIFT + order.

    This one is very good after changing + order. I updated
    alloc_page_interleave to get an order parameter but I didn't adjust
    the nid accordingly to order. This was my incomplete modification for
    hpage interleaving:

    @@ -1830,7 +1832,7 @@ alloc_page_vma(gfp_t gfp, struct vm_area_struct
    *vma, unsigned long addr)

    nid = interleave_nid(pol, vma, addr, PAGE_SHIFT);
    mpol_cond_put(pol);
    - page = alloc_page_interleave(gfp, 0, nid);
    + page = alloc_page_interleave(gfp, order, nid);
    put_mems_allowed();
    return page;
    }


    Andi, can you resubmit this one fixd with + to Andrew, this one can go
    in 2.6.38. For the rest frankly I've an hard time to see how it cannot
    hurt performance (instead of improving them) especially for KSM. It's
    impossible to improve KSM for NUMA with that change to
    ksm_does_need_to_copy at the very least. But the same reasoning
    applies to the rest. But I'll think more about the others, I just
    would prefer to include the above fix quick, the rest don't seem that
    urgent even if it's really improving performance (instead of hurting
    it as I think).

    Acked-by: Andrea Arcangeli <aarcange@redhat.com>


    \
     
     \ /
      Last update: 2011-02-22 17:31    [W:0.048 / U:0.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site