lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] staging: remove null checks before kfree
    On Tue, Feb 22, 2011 at 03:53:40AM -0500, Ilia Mirkin wrote:
    > This patch was created with the following semantic patch:
    >
    > // <smpl>
    > @@
    > expression E;
    > @@
    >
    > - if (E != NULL) kfree(E);
    > + kfree(E);
    > // </smpl>
    >
    > Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
    > ---
    >
    > Hi Greg,
    >
    > Please let me know if you would rather I split these up by driver instead.
    > I didn't because I saw that you took staging-wide cleanups before.

    Please split these up per-driver, it makes it easier to merge and for
    the individual driver authors to review them.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2011-02-22 16:03    [W:0.027 / U:29.804 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site