Messages in this thread | | | Date | Tue, 22 Feb 2011 13:52:58 +0100 | From | "Eibach, Dirk" <> | Subject | RE: [PATCH] gpio: Fix wrong pointer type in pca953x |
| |
> > struct pca953x_platform_data *pdata; > > struct device_node *node; > > - const uint16_t *val; > > + const u32 *val; > > > > This should probably be signed? We compare it against zero later on. > > if (*val < 0) > dev_warn(&client->dev, > "invalid gpio-base in device > tree\n");
Good catch. of property values are generally unsigned. The whole check is bogus here. Will supply updated patch later.
> regards, > dan carpenter
Cheers Dirk
| |