lkml.org 
[lkml]   [2011]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] random: update interface comments to reflect reality
On Thu, Feb 17, 2011 at 04:29:14PM -0600, Matt Mackall wrote:
> On Thu, 2011-02-17 at 17:23 -0500, Jarod Wilson wrote:
> > At present, the comment header in random.c makes no mention of
> > add_disk_randomness, and instead, suggests that disk activity adds to the
> > random pool by way of add_interrupt_randomness, which appears to not have
> > been the case since sometime prior to the existence of git, and even prior
> > to bitkeeper. Didn't look any further back. At least, as far as I can
> > tell, there are no storage drivers setting IRQF_SAMPLE_RANDOM, which is a
> > requirement for add_interrupt_randomness to trigger, so the only way for a
> > disk to contribute entropy is by way of add_disk_randomness. Update
> > comments accordingly, complete with special mention about solid state
> > drives being a crappy source of entropy (see e2e1a148bc for reference).
> >
> > Signed-off-by: Jarod Wilson <jarod@redhat.com>
>
> Sure. Herbert, let's route this through your crypto tree.
>
> Acked-by: Matt Mackall <mpm@selenic.com>

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2011-02-21 11:45    [W:0.034 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site