lkml.org 
[lkml]   [2011]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/mm] x86-64, NUMA: Restructure initmem_init()
On Sat, Feb 19, 2011 at 07:34:57PM -0800, David Rientjes wrote:
> This doesn't look very clean, I think it would be much better to extract
> the iteration out to a function of its own which takes an init and scan
> function as arguments and then deal only with numa_off, CONFIG_ACPI_NUMA,
> and CONFIG_AMD_NUMA callers in initmem_init(). If that's done, it's clear
> that the dummy implementation will never fail and so the BUG() in this
> case is never possible (which is intended if all else fails).

I don't know. Maybe. Care to send a patch?

--
tejun


\
 
 \ /
  Last update: 2011-02-21 09:37    [W:0.070 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site