Messages in this thread | | | Date | Mon, 21 Feb 2011 09:35:11 +0100 | From | Tejun Heo <> | Subject | Re: [tip:x86/mm] x86-64, NUMA: Restructure initmem_init() |
| |
On Sat, Feb 19, 2011 at 07:34:57PM -0800, David Rientjes wrote: > This doesn't look very clean, I think it would be much better to extract > the iteration out to a function of its own which takes an init and scan > function as arguments and then deal only with numa_off, CONFIG_ACPI_NUMA, > and CONFIG_AMD_NUMA callers in initmem_init(). If that's done, it's clear > that the dummy implementation will never fail and so the BUG() in this > case is never possible (which is intended if all else fails).
I don't know. Maybe. Care to send a patch?
-- tejun
| |