lkml.org 
[lkml]   [2011]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] PRUSS UIO driver support
    Hello.

    Hans J. Koch wrote:

    >>> -----Original Message-----
    >>> From: Hans J. Koch [mailto:hjk@hansjkoch.de]
    >>> Sent: Sunday, February 20, 2011 12:04 AM
    >>> To: TK, Pratheesh Gangadhar
    >>> Cc: Thomas Gleixner; Arnd Bergmann; linux-arm-kernel@lists.infradead.org;
    >>> davinci-linux-open-source@linux.davincidsp.com; gregkh@suse.de;
    >>> Chatterjee, Amit; Hans J. Koch; LKML
    >>> Subject: Re: [PATCH 1/2] PRUSS UIO driver support

    >>> On Sat, Feb 19, 2011 at 09:10:23PM +0530, TK, Pratheesh Gangadhar wrote:
    >>>> For my understanding - if the interrupt is not shared and not level triggered -
    >>>> is this okay to have empty handler?

    >>> Greg already said he won't accept that. And I'm quite sure these
    >>> interrupts
    >>> are level triggered, since that is the default on arch/omap.

    >>> E.g. in arch/arm/mach-omap1/irq.c, a loop sets all irqs to level triggered
    >>> handling: set_irq_handler(j, handle_level_irq); (line 234)

    >> You should be looking at arch/arm/mach-davinci/irq.c

    Into arch/arm/mach-davinci/cp_intc.c actually as we're not talking about a
    "real" DaVincis here, but about OMAP-L138.

    > Hmpf. I alway get lost in the directory structure of TI SoCs...
    > At least I learned that OMAP3 is in the omap2 directory :)

    It's probably even more convoluted with DaVinci and friends. :-)

    >> and all interrupts except IRQ_TINT1_TINT34 is set to edge trigger mode (line 160).

    > Is that really needed? Level triggered interrupts should certainly be
    > preferred if possible.

    Don't look there, this code is for "real" DaVincis only.

    > Thanks,
    > Hans

    WBR, Sergei


    \
     
     \ /
      Last update: 2011-02-21 20:57    [W:0.024 / U:29.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site