Messages in this thread | | | Date | Mon, 21 Feb 2011 14:09:39 +0800 | From | Gui Jianfeng <> | Subject | [PATCH 0/6 v5] cfq-iosched: Introduce CFQ group hierarchical scheduling and "use_hierarchy" interface |
| |
Hi
Previously, I posted a patchset to add support of CFQ group hierarchical scheduling in the way that it puts all CFQ queues in a hidden group and schedules with other CFQ group under their parent. The patchset is available here, http://lkml.org/lkml/2010/8/30/30
Vivek think this approach isn't so instinct that we should treat CFQ queues and groups at the same level. Here is the new approach for hierarchical scheduling based on Vivek's suggestion. The most big change of CFQ is that it gets rid of cfq_slice_offset logic, and makes use of vdisktime for CFQ queue scheduling just like CFQ group does. But I still give cfqq some jump in vdisktime based on ioprio, thanks for Vivek to point out this. Now CFQ queue and CFQ group use the same scheduling algorithm.
"use_hierarchy" interface is now added to switch between hierarchical mode and flat mode. It works as memcg.
V4 -> V5 Changes: - Change boosting base to a smaller value. - Rename repostion_time to position_time - Replace duplicated code by calling cfq_scale_slice() - Remove redundant use_hierarchy in cfqd - Fix grp_service_tree comment - Rename init_cfqe() to init_group_cfqe()
-- V3 -> V4 Changes: - Take io class into account when calculating the boost value. - Refine the vtime boosting logic as Vivek's Suggestion. - Make the calculation of group slice cross all service trees under a group. - Modify Documentation in terms of Vivek's comments.
-- V2 -> V3 Changes: - Starting from cfqd->grp_service_tree for both hierarchical mode and flat mode - Avoid recursion when allocating cfqg and force dispatch logic - Fix a bug when boosting vdisktime - Adjusting total_weight accordingly when changing weight - Change group slice calculation into a hierarchical way - Keep flat mode rather than deleting it first then adding it later - kfree the parent cfqg if there nobody references to it - Simplify select_queue logic by using some wrap function - Make "use_hierarchy" interface work as memcg - Make use of time_before() for vdisktime compare - Update Document - Fix some code style problems
-- V1 -> V2 Changes: - Raname "struct io_sched_entity" to "struct cfq_entity" and don't differentiate queue_entity and group_entity, just use cfqe instead. - Give newly added cfqq a small vdisktime jump accord to its ioprio. - Make flat mode as default CFQ group scheduling mode. - Introduce "use_hierarchy" interface. - Update blkio cgroup documents
Documentation/cgroups/blkio-controller.txt | 81 +- block/blk-cgroup.c | 61 + block/blk-cgroup.h | 3 block/cfq-iosched.c | 959 ++++++++++++++++++++--------- 4 files changed, 815 insertions(+), 289 deletions(-)
Thanks, Gui
| |