lkml.org 
[lkml]   [2011]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] userns: let clone_uts_ns() handle setting uts->user_ns
    Quoting Oleg Nesterov (oleg@redhat.com):
    > On 02/21, Daniel Lezcano wrote:
    > >
    > > On 02/21/2011 05:01 AM, Serge E. Hallyn wrote:
    > >> To do so we need to pass in the task_struct who'll get the utsname,
    > >> so we can get its user_ns.
    > >>
    > >> -extern struct uts_namespace *copy_utsname(unsigned long flags,
    > >> - struct uts_namespace *ns);
    > >> +extern struct uts_namespace *copy_utsname(struct task_struct *tsk,
    > >> + unsigned long flags,
    > >> + struct uts_namespace *ns);
    > >
    > > Why don't we pass 'user_ns' instead of 'tsk' ? that will look
    > > semantically clearer for the caller no ?
    > > (example below).
    > > ...
    > >
    > > new_nsp->uts_ns = copy_utsname(flags, tsk->nsproxy->uts_ns, task_cred_xxx(tsk, user)->user_ns);
    >
    > To me tsk looks more readable, I mean
    >
    > new_nsp->uts_ns = copy_utsname(flags, tsk);
    >
    > copy_utsname() can find both uts_ns and user_ns looking at task_strcut.

    Uh, yeah. I should remove the 'ns' argument there shouldn't I.

    Daniel, does that sway your opinion then?

    thanks,
    -serge


    \
     
     \ /
      Last update: 2011-02-21 15:01    [W:4.602 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site