lkml.org 
[lkml]   [2011]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch -next] x86, microcode, AMD: signedness bug in generic_load_microcode()
On Sun, Feb 20, 2011 at 02:02:14PM +0100, Ingo Molnar wrote:
>
> * Dan Carpenter <error27@gmail.com> wrote:
>
> > install_equiv_cpu_table() returns type int. It uses negative error
> > codes so using an unsigned type breaks the error handling.
>
> How did you notice this btw - did GCC throw a warning?
>

It's a smatch warning.

arch/x86/kernel/microcode_amd.c +256 generic_load_microcode(12)
warn: unsigned 'offset' is never less than zero.

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-02-20 14:13    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean