lkml.org 
[lkml]   [2011]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 12/21] ARM: tegra: clock: Add shared bus clock type
    From
    Hi,

    On Sat, Feb 19, 2011 at 2:25 PM, Colin Cross <ccross@android.com> wrote:
    > Some clocks may have multiple downstream users that need to request a
    > higher clock rate.  Shared bus clocks provide a unique shared_bus_user
    > clock to each user.  The frequency of the bus is set to the highest
    > enabled shared_bus_user clock, with a minimum value set by the
    > shared bus.  Drivers can use clk_enable and clk_disable to enable
    > or disable their requirement, and clk_set_rate to set the minimum rate.
    >
    > Signed-off-by: Colin Cross <ccross@android.com>

    [...]
    > diff --git a/arch/arm/mach-tegra/tegra2_clocks.c b/arch/arm/mach-tegra/tegra2_clocks.c
    > index a1c86d8..dd53af3 100644
    > --- a/arch/arm/mach-tegra/tegra2_clocks.c
    > +++ b/arch/arm/mach-tegra/tegra2_clocks.c
    [...]

    > +       c->u.shared_bus_user.rate = c->parent->max_rate;
    > +       c->state = OFF;
    > +#ifdef CONFIG_DEBUG_FS
    > +       c->set = 1;
    > +#endif
    > +
    > +       spin_lock_irqsave(&c->parent->spinlock, flags);


    A later patch in the series removes the ifdef. Might as well remove it
    here. Also, should be c->set = true, which that patch also does. :)

    With that fixed:

    Acked-by: Olof Johansson <olof@lixom.net>
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-21 05:17    [W:0.022 / U:32.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site