lkml.org 
[lkml]   [2011]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/10] Add yaffs2 file system: Fifth patchset
    On 02/21/2011 09:07 AM, Greg KH wrote:
    > On Mon, Feb 21, 2011 at 06:25:08AM +1300, Charles Manning wrote:
    >> On Friday 18 February 2011 13:58:52 Greg KH wrote:
    >> I still intend to keep the tracing printk-based tracing:
    >>
    >> #define yaffs_trace(msk, fmt, ...) do { \
    >> if (yaffs_trace_mask & (msk)) \
    >> printk(KERN_DEBUG "yaffs: " fmt "\n", ##__VA_ARGS__); \
    >> } while (0)
    >
    > No, please don't invent your own stuff like this, again, use the
    > in-kernel functionality provided for this.

    Do you mean using pr_debug? Other filesystems (see for example
    fs/ubifs/debug.h:dbg_do_msg) and drivers have similar approaches to this
    to allow printk debugging with multiple message levels.

    ~Ryan

    --
    Bluewater Systems Ltd - ARM Technology Solution Centre

    Ryan Mallon 5 Amuri Park, 404 Barbadoes St
    ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
    http://www.bluewatersys.com New Zealand
    Phone: +64 3 3779127 Freecall: Australia 1800 148 751
    Fax: +64 3 3779135 USA 1800 261 2934


    \
     
     \ /
      Last update: 2011-02-20 21:53    [W:0.019 / U:2.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site