lkml.org 
[lkml]   [2011]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 18/28] posix-timers: Convert timer_delete() to clockid_to_kclock()
On Wed, 2 Feb 2011, Richard Cochran wrote:

> On Tue, Feb 01, 2011 at 01:52:07PM -0000, Thomas Gleixner wrote:
> > Index: linux-2.6-tip/kernel/posix-timers.c
> > ===================================================================
> > --- linux-2.6-tip.orig/kernel/posix-timers.c
> > +++ linux-2.6-tip/kernel/posix-timers.c
> > @@ -254,6 +254,7 @@ static __init int init_posix_timers(void
> > .timer_create = common_timer_create,
> > .timer_set = common_timer_set,
> > .timer_get = common_timer_get,
> > + .timer_del = common_timer_del,
> > };
> > struct k_clock clock_monotonic = {
> > .clock_getres = hrtimer_get_res,
> > @@ -263,6 +264,7 @@ static __init int init_posix_timers(void
> > .timer_create = common_timer_create,
> > .timer_set = common_timer_set,
> > .timer_get = common_timer_get,
> > + .timer_del = common_timer_del,
> > };
> > struct k_clock clock_monotonic_raw = {
> > .clock_getres = hrtimer_get_res,
>
> The definition of common_timer_del() should not be "inline" since the
> address of the function is in these tables. The declaration is not
> inline, and gcc 4.2.4 gives a warning.
>
> (But strangly, newer versions do not).

Will fix. Thanks.

tglx


\
 
 \ /
  Last update: 2011-02-02 10:57    [W:0.075 / U:2.212 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site