lkml.org 
[lkml]   [2011]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [Patch] kexec: remove KMSG_DUMP_KEXEC (was Re: Query about kdump_msg hook into crash_kexec())
    Date
    > On Tue, Feb 01, 2011 at 03:38:53PM +0800, Américo Wang wrote:
    > >On Mon, Jan 31, 2011 at 11:33:15PM -0800, Eric W. Biederman wrote:
    > >>The issue is the inane call inside crash_kexec.
    > >>
    > >>It requires both a kexec kernel to be loaded and it requires you to be
    > >>crashing. Given that when I audited the kmsg_dump handlers they really
    > >>weren't safe in a crash dump scenario we should just remove it.
    > >>
    > >
    > >Probably, I think we need to get rid of KMSG_DUMP_KEXEC.
    > >
    >
    > Here we go.
    >
    > --------->
    >
    > KMSG_DUMP_KEXEC is useless because we already save kernel messages
    > inside /proc/vmcore, and it is unsafe to allow modules to do
    > other stuffs in a crash dump scenario.
    >
    > Reported-by: Vivek Goyal <vgoyal@redhat.com>
    > Cc: "Eric W. Biederman" <ebiederm@xmission.com>
    > Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

    I wrote why this is no good idea by another mail. Please see it.
    Anyway you have a right to don't use this feature.

    Nack.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-03 02:01    [from the cache]
    ©2003-2011 Jasper Spaans