lkml.org 
[lkml]   [2011]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix EDD3.0 data verification.
On 02/02/2011 09:59 AM, Gleb Natapov wrote:
>
> Ah I see what length you were referring to params->device_path_info_length.
> If we will use that then we will get correct checksum for BIOSes that work
> according to phoenix spec too, but edd_show_interface() and edd_show_host_bus()
> handle only T13 spec so the information they show can be incorrect. I can
> change code to check that params->device_path_info_length == 44 in addition
> to checking csum. What do you think?
>

Yes, you need to check both.

This is really a union of two similar-but-not-identical structures
distinguished by the length field.

-hpa


\
 
 \ /
  Last update: 2011-02-02 20:59    [W:0.040 / U:9.556 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site