lkml.org 
[lkml]   [2011]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drivers/mtd/maps/ts5500_flash.c: avoid calling map_destroy on NULL
Date
map_destroy dereferences its argument.  The call is furthermore only
reachable when this argument is NULL. Thus the call is dropped.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression *x;
@@

*if (x == NULL)
{ ...
* map_destroy(x);
...
return ...;
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
drivers/mtd/maps/ts5500_flash.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/maps/ts5500_flash.c b/drivers/mtd/maps/ts5500_flash.c
index e2147bf..e02dfa9 100644
--- a/drivers/mtd/maps/ts5500_flash.c
+++ b/drivers/mtd/maps/ts5500_flash.c
@@ -94,7 +94,6 @@ static int __init init_ts5500_map(void)
return 0;

err1:
- map_destroy(mymtd);
iounmap(ts5500_map.virt);
err2:
return rc;


\
 
 \ /
  Last update: 2011-02-02 17:55    [W:0.026 / U:0.224 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site