Messages in this thread Patch in this message | | | Subject | [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses | From | Joe Perches <> | Date | Sat, 19 Feb 2011 20:46:54 -0800 |
| |
Add quotes around email address with periods and commas.
Signed-off-by: Joe Perches <joe@perches.com> --- On Sun, 2011-02-20 at 10:48 +0800, Harry Wei wrote: > On Sun, Feb 20, 2011 at 10:38:06AM +0800, harryxiyou wrote: > > From: Joe Perches <joe@perches.com> > > On Sat, 2011-02-19 at 17:48 +0100, Pavel Machek wrote: > > > On Wed 2011-02-09 19:17:52, David Miller wrote: > > > > From: Andrew Morton <akpm@linux-foundation.org> > > > > > I suspect that some mail clients will explode if you provide them with > > > > > an unquoted string containing periods. That would make copy-n-paste > > > > > rather a hassle. > > > > It's not clients, it's servers. > > > > SMTP rules state that characters such as "." cannot appear > > > > unquoted in email headers. > > > > vger.kernel.org rejects mail when this violation occurs. > > > Ok, but should not MUA do this quotation? Quick test shows that mutt > > does... > > My recollection is that the get_maintainer script > > cannot parse M: lines with multiple entries with > > periods without the quotes. > > M: First I. Last <fil@foo.bar>, Last.I.First <lif@foo.bar> > > fails and > > M: "First I. Last" <fil@foo.bar>, "Last.I.First" <lif@foo.bar> > > succeeds. > > You are welcome to improve the parsing in that routine. > In order to improve the parsing in that routine we should remove all > the the double-quotation-marks in the MAINTAINERS ?
No, that'd be wrong before improving parsing and verifying that all currently used client/MUAs work without quotes.
> Maybe we have other better ways? Tell me and i will patch for us.
I think leaving the quotes is the right thing to do.
Quoting names that have non alphanumeric characters before any open angle bracket '<' is better than remove quotes.
MAINTAINERS | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS index e45eabe..af586f8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1044,7 +1044,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained ARM/TETON BGA MACHINE SUPPORT -M: Mark F. Brown <mark.brown314@gmail.com> +M: "Mark F. Brown" <mark.brown314@gmail.com> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained @@ -1448,7 +1448,7 @@ F: drivers/mtd/devices/block2mtd.c BLUETOOTH DRIVERS M: Marcel Holtmann <marcel@holtmann.org> -M: Gustavo F. Padovan <padovan@profusion.mobi> +M: "Gustavo F. Padovan" <padovan@profusion.mobi> L: linux-bluetooth@vger.kernel.org W: http://www.bluez.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git @@ -1457,7 +1457,7 @@ F: drivers/bluetooth/ BLUETOOTH SUBSYSTEM M: Marcel Holtmann <marcel@holtmann.org> -M: Gustavo F. Padovan <padovan@profusion.mobi> +M: "Gustavo F. Padovan" <padovan@profusion.mobi> L: linux-bluetooth@vger.kernel.org W: http://www.bluez.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git @@ -2909,7 +2909,7 @@ F: Documentation/blockdev/cpqarray.txt F: drivers/block/cpqarray.* HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa) -M: Stephen M. Cameron <scameron@beardog.cce.hp.com> +M: "Stephen M. Cameron" <scameron@beardog.cce.hp.com> L: iss_storagedev@hp.com S: Supported F: Documentation/scsi/hpsa.txt @@ -4197,7 +4197,7 @@ F: Documentation/serial/moxa-smartio F: drivers/char/mxser.* MSI LAPTOP SUPPORT -M: Lee, Chun-Yi <jlee@novell.com> +M: "Lee, Chun-Yi" <jlee@novell.com> L: platform-driver-x86@vger.kernel.org S: Maintained F: drivers/platform/x86/msi-laptop.c
| |