lkml.org 
[lkml]   [2011]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC()
On Thu, 17 Feb 2011, Li Zefan wrote:

> Those functions that use NODEMASK_ALLOC() can't propogate errno
> to users, but will fail silently.
>
> Since all of them are called with cgroup_mutex held, here we use
> a global nodemask_t variable.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

I like the idea and the comment is explicit enough that we don't need any
refcounting to ensure double usage under cgroup_lock. I think each
function should be modified to use cpuset_mems directly, though, instead
of defining local variables that indirectly access it which only serves to
make this patch smaller. Then we can ensure that all occurrences of
cpuset_mems appear within the lock without being concerned about other
references.


\
 
 \ /
  Last update: 2011-02-20 02:55    [from the cache]
©2003-2011 Jasper Spaans