lkml.org 
[lkml]   [2011]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 11/12] unicore32 machine related files: ps2 driver
    Date
    On Friday 18 February 2011 11:28:45 Guan Xuetao wrote:
    > * Register numbers.
    > */
    > -#define I8042_COMMAND_REG ((unsigned long)&PS2_COMMAND)
    > -#define I8042_STATUS_REG ((unsigned long)&PS2_STATUS)
    > -#define I8042_DATA_REG ((unsigned long)&PS2_DATA)
    > +#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND)
    > +#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS)
    > +#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA)
    > +
    > +#define I8042_REGION_START (resource_size_t)(&PS2_DATA)
    > +#define I8042_REGION_SIZE (resource_size_t)(16)

    It would be better to remove the cast and make the PS2_COMMAND
    etc macros have the correct type. Aside from this, the change
    looks good.

    Arnd


    \
     
     \ /
      Last update: 2011-02-18 11:35    [W:3.690 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site