Messages in this thread | | | Date | Fri, 18 Feb 2011 10:58:03 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] gpio: add trace events for setting direction and value |
| |
Hi Steven, hi Grant,
On Wed, Feb 16, 2011 at 12:12:51PM -0500, Steven Rostedt wrote: > Note: to save the memory footprint of these tracepoints, you can use > DEFINE_EVENT_PRINT(). You can see the usage for this in the > include/trace/events/kmem.h. > But to do this, you will need to have a single TP_STRUCT__entry() for > both. Not sure if this is what you want. > > TP_STRUCT__entry( > __field(unsigned, gpiq) > __field(int, get_in) > __field(int, value_err) > > ?? > > Just a suggestion, but may not be worth it. Yeah, I saw that, still I think it's sane to keep them seperated. Or how much would we save? Can you estimate that?
@Grant: Steven told me this should go via your tree, so if you are OK with the change, feel free to take it.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |