| Date | Fri, 18 Feb 2011 16:01:24 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 6/9] user namespaces: convert all capable checks in kernel/sys.c |
| |
On Thu, 17 Feb 2011 15:03:42 +0000 "Serge E. Hallyn" <serge@hallyn.com> wrote:
> @@ -1177,8 +1189,11 @@ SYSCALL_DEFINE2(sethostname, char __user *, name, int, len) > int errno; > char tmp[__NEW_UTS_LEN]; > > - if (!ns_capable(current->nsproxy->uts_ns->user_ns, CAP_SYS_ADMIN)) > + if (!ns_capable(current->nsproxy->uts_ns->user_ns, CAP_SYS_ADMIN)) { > + printk(KERN_NOTICE "%s: did not have CAP_SYS_ADMIN\n", __func__); > return -EPERM; > + } > + printk(KERN_NOTICE "%s: did have CAP_SYS_ADMIN\n", __func__); > if (len < 0 || len > __NEW_UTS_LEN) > return -EINVAL; > down_write(&uts_sem);
Left over debugging printks?
|