Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH]: Staging: hv: Allocate the vmbus irq dynamically | Date | Fri, 18 Feb 2011 22:00:04 +0000 |
| |
> -----Original Message----- > From: Greg KH [mailto:greg@kroah.com] > Sent: Friday, February 18, 2011 4:14 PM > To: KY Srinivasan > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; virtualization@lists.osdl.org > Subject: Re: [PATCH]: Staging: hv: Allocate the vmbus irq dynamically > > On Tue, Feb 15, 2011 at 11:55:35AM -0800, K. Y. Srinivasan wrote: > > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > > Signed-off-by: Hank Janssen <hjanssen@microsoft.com> > > You didn't run this through checkpatch.pl. > > Please do so and fix the warning it gives you. Greg, I did run the checkpatch script against this patch and the only complaint I got was with regards to the IRQF_SAMPLE_RANDOM flag that I pass. As a virtual machine, this is the only external event that the VM is going to see and so I chose to keep this flag. Is there something that would replace this flag; looking at the Xen drivers they do pass this flag.
Regards,
K. Y
> > thanks, > > greg k-h
| |