lkml.org 
[lkml]   [2011]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 13/13] tty: pruss SUART driver
    On Fri, 18 Feb 2011, Alan Cox wrote:

    > On Fri, 18 Feb 2011 19:17:38 +0530
    > "Subhasish Ghosh" <subhasish@mistralsolutions.com> wrote:
    >
    > > Hello,
    > >
    > > Regarding the semaphore to mutex migration.
    > > We are using down_trylock in interrupt context,
    > > mutex_trylock cannot be used in interrupt context, so we cannot use mutex in
    > > our driver.
    >
    > Then you probably need to rework your locking. Best bet might be to fix
    > all the other stuff and report the driver, and people can think about the
    > locking problem.

    That semaphore is utterly useless to begin with. There are more
    serious locking problems than this one. Non serialized calls to
    suart_intr_clrmask/suart_intr_setmask are the most obvious ones.

    Aside of that the code is complete unreadable.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2011-02-18 19:27    [W:0.022 / U:1.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site