Messages in this thread Patch in this message | | | Date | Thu, 17 Feb 2011 19:58:14 +0800 | Subject | Re: [PATCH] code cleanup on include/linux/fs.h | From | Steven Liu <> |
| |
Hi Alexey Dobriyan,
Signed-off-by: LiuQi <lingjiujianke@gmail.com> --- fs/super.c | 31 ------------------------------- 1 files changed, 0 insertions(+), 31 deletions(-)
diff --git a/fs/super.c b/fs/super.c index 7e9dd4c..8272f26 100644 --- a/fs/super.c +++ b/fs/super.c @@ -843,22 +843,6 @@ error: } EXPORT_SYMBOL(mount_bdev);
-int get_sb_bdev(struct file_system_type *fs_type, - int flags, const char *dev_name, void *data, - int (*fill_super)(struct super_block *, void *, int), - struct vfsmount *mnt) -{ - struct dentry *root; - - root = mount_bdev(fs_type, flags, dev_name, data, fill_super); - if (IS_ERR(root)) - return PTR_ERR(root); - mnt->mnt_root = root; - mnt->mnt_sb = root->d_sb; - return 0; -} - -EXPORT_SYMBOL(get_sb_bdev);
void kill_block_super(struct super_block *sb) { @@ -897,21 +881,6 @@ struct dentry *mount_nodev(struct file_system_type *fs_type, } EXPORT_SYMBOL(mount_nodev);
-int get_sb_nodev(struct file_system_type *fs_type, - int flags, void *data, - int (*fill_super)(struct super_block *, void *, int), - struct vfsmount *mnt) -{ - struct dentry *root; - - root = mount_nodev(fs_type, flags, data, fill_super); - if (IS_ERR(root)) - return PTR_ERR(root); - mnt->mnt_root = root; - mnt->mnt_sb = root->d_sb; - return 0; -} -EXPORT_SYMBOL(get_sb_nodev);
static int compare_single(struct super_block *s, void *p) { -- 1.6.5.2
Best Regards
Steven Liu
2011/2/17 Alexey Dobriyan <adobriyan@gmail.com>: > On Thu, Feb 17, 2011 at 11:37 AM, Steven Liu <lingjiujianke@gmail.com> wrote: >> Cleanup the unsed code on include/linux/fs.h. >> All filesystem using mount_bdev and mount_nodev >> to replace get_sb_bdev and get_sb_nodev. >> So rmmove the unused code. > >> -extern int get_sb_bdev(struct file_system_type *fs_type, >> - int flags, const char *dev_name, void *data, >> - int (*fill_super)(struct super_block *, void *, int), >> - struct vfsmount *mnt); >> extern struct dentry *mount_single(struct file_system_type *fs_type, >> int flags, void *data, >> int (*fill_super)(struct super_block *, void *, int)); >> @@ -1821,10 +1817,6 @@ extern int get_sb_single(struct >> file_system_type *fs_type, >> extern struct dentry *mount_nodev(struct file_system_type *fs_type, >> int flags, void *data, >> int (*fill_super)(struct super_block *, void *, int)); >> -extern int get_sb_nodev(struct file_system_type *fs_type, >> - int flags, void *data, >> - int (*fill_super)(struct super_block *, void *, int), >> - struct vfsmount *mnt); > > The functions themselves are still in place, what's up? > > fs/super.c:846:int get_sb_bdev(struct file_system_type *fs_type, > fs/super.c:861:EXPORT_SYMBOL(get_sb_bdev); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |