lkml.org 
[lkml]   [2011]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/8] mm: Remove i_mmap_mutex lockbreak
    On Thu, 17 Feb 2011 18:05:22 +0100
    Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

    > Hugh says:
    > "The only significant loser, I think, would be page reclaim (when
    > concurrent with truncation): could spin for a long time waiting for
    > the i_mmap_mutex it expects would soon be dropped? "
    >
    > Counter points:
    > - cpu contention makes the spin stop (need_resched())
    > - zap pages should be freeing pages at a higher rate than reclaim
    > ever can
    > - shouldn't hold up reclaim more than lock_page() would
    >
    > I think the simplification of the truncate code is definately worth
    > it.
    >
    > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

    Maybe I have to improve batched-uncharge in memcg, whose work depends
    on ZAP_BLOCK_SIZE....but the zap routine seems cleaner.

    Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>



    \
     
     \ /
      Last update: 2011-02-17 18:55    [W:3.183 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site