Messages in this thread | | | Date | Thu, 17 Feb 2011 18:25:59 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/3] x86-64: use relative 32-bit pointers in exception tables |
| |
Nice patch. I've got a really small code readability nitpick:
> +#ifndef ex_insn /* until all architectures have this accessor */ > +#define ex_insn(x) (x)->insn > +#endif
> +#else > +#define swap_ex NULL > +#endif
In the x86 architecture we tend to write this as:
> +#else > +# define swap_ex NULL > +#endif
So that the conditional structure stands out more, visually. (There might be more such cases in these patches as well.)
Thanks,
Ingo
| |