Messages in this thread | | | From | Grant Likely <> | Date | Thu, 17 Feb 2011 09:46:30 -0700 | Subject | Re: [sodaville] [PATCH OF 13/14] rtc/cmos: add OF bindings |
| |
On Thu, Feb 17, 2011 at 6:26 AM, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > * Grant Likely | 2011-02-16 15:11:08 [-0700]: > >>> diff --git a/Documentation/powerpc/dts-bindings/rtc-cmos.txt b/Documentation/powerpc/dts-bindings/rtc-cmos.txt >>> new file mode 100644 >>> index 0000000..7382989 >>> --- /dev/null >>> +++ b/Documentation/powerpc/dts-bindings/rtc-cmos.txt >> >>Move to Documentation/devicetree/bindings/rtc/ > moved. > >>> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c >>> index c7ff8df..2709e00 100644 >>> --- a/drivers/rtc/rtc-cmos.c >>> +++ b/drivers/rtc/rtc-cmos.c >>> @@ -1162,6 +1205,9 @@ static struct platform_driver cmos_platform_driver = { >>> #ifdef CONFIG_PM >>> .pm = &cmos_pm_ops, >>> #endif >>> +#if defined(CONFIG_OF) >>> + .of_match_table = of_cmos_match, >>> +#endif >> >>The #if defined(CONFIG_OF) is no longer necessary around >>.of_match_table, particularly if you have a #else above that #defines >>of_cmos_match to NULL. > > Kinda does not work. I get here: > |drivers/rtc/rtc-cmos.c:1209:3: error: unknown field â of_match_tableâ specified in initializer > > I rebased on top of -rc5. Is this something new you describing?
Base your patch on top of my devicetree/next branch. That's the branch that tglx will be applying them on top of them to get your changes to generic pci dt support code.
g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |