Messages in this thread | | | Date | Thu, 17 Feb 2011 01:53:50 +0000 | From | Al Viro <> | Subject | please, remove the abuse of vfs_path_lookup() in ecryptfs |
| |
commit 21edad32205e97dc7ccb81a85234c77e760364c8 ( ecryptfs: dont call lookup_one_len to avoid NULL nameidata) is badly misguided. The last thing we need is extra places where nameidata is passed around.
The current code is simply wrong - it's bypassing dcache lookups in new_lower_dentry(). Besides, abuse of vfs_path_lookup() here is a Bad Idea(tm). No, filesystems are *not* allowed to die if ->d_revalidate()/->lookup()/->create() are called with NULL nameidata. Eventually these methods will lose nameidata * anyway - starting with ->d_revalidate() in the next cycle at the latest (i.e. if we run into something really stinky in RCU mess, it might happen before -final).
Please revert that.
| |