lkml.org 
[lkml]   [2011]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/6] perf annotate: Check if offset is less than symbol size
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    Just like done on symbol__inc_addr_samples to catch misparsed offsets
    from objdump.

    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Tom Zanussi <tzanussi@gmail.com>
    LKML-Reference: <new-submission>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/annotate.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
    index 02976b8..70ec422 100644
    --- a/tools/perf/util/annotate.c
    +++ b/tools/perf/util/annotate.c
    @@ -541,11 +541,12 @@ void symbol__annotate_decay_histogram(struct symbol *sym, int evidx)
    struct annotation *notes = symbol__annotation(sym);
    struct sym_hist *h = annotation__histogram(notes, evidx);
    struct objdump_line *pos;
    + int len = sym->end - sym->start;

    h->sum = 0;

    list_for_each_entry(pos, &notes->src->source, node) {
    - if (pos->offset != -1) {
    + if (pos->offset != -1 && pos->offset < len) {
    h->addr[pos->offset] = h->addr[pos->offset] * 7 / 8;
    h->sum += h->addr[pos->offset];
    }
    --
    1.6.2.5


    \
     
     \ /
      Last update: 2011-02-16 23:59    [W:0.022 / U:0.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site