lkml.org 
[lkml]   [2011]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, numa: refactoring numa_register_memblks
Hello,

On Wed, Feb 16, 2011 at 12:58:41PM -0800, Yinghai Lu wrote:
>
> Don't hide init_memory_mapping and setup_bootmem into that __register__ function
>
> those are really work.

What does that mean? What isn't really work?

> Also We don't need to scan two times for setup_node_bootmem() becase we
> are using mapped memblock for node_data already.

If this isn't necessary, please make this change in a separate patch.
This involves behavior change.

> @@ -968,6 +969,10 @@ void __init initmem_init(void)
> if (numa_register_memblks(&numa_meminfo) < 0)
> continue;
>
> + init_memory_mapping_high();
> +
> + setup_numa_bootmem(&numa_meminfo);
> +

Sorry, nack. This squarely falls in the realm of bikeshedding and I
plan on collapsing init_memory_mapping_high() into the register
function.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-02-16 23:45    [from the cache]
©2003-2011 Jasper Spaans