Messages in this thread | | | Date | Wed, 16 Feb 2011 08:52:48 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2] olpc_battery: convert to platform device |
| |
On Wed, Feb 16, 2011 at 02:29:31PM +0000, Daniel Drake wrote: > > -static void __exit olpc_bat_exit(void) > +static int __exit olpc_battery_remove(struct platform_device *pdev) ... > + .remove = __devexit_p(olpc_battery_remove),
olpc_battery_remove should be annotated as __devexit. Sorry for not noticing this before. Otherwise:
Reviewed-by: Dmitry Torokhov <dtor@mail.ru>
Thanks.
-- Dmitry
| |