lkml.org 
[lkml]   [2011]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] olpc_battery: convert to platform device
On Wed, Feb 16, 2011 at 02:29:31PM +0000, Daniel Drake wrote:
>
> -static void __exit olpc_bat_exit(void)
> +static int __exit olpc_battery_remove(struct platform_device *pdev)
...
> + .remove = __devexit_p(olpc_battery_remove),

olpc_battery_remove should be annotated as __devexit. Sorry for not
noticing this before. Otherwise:

Reviewed-by: Dmitry Torokhov <dtor@mail.ru>

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2011-02-16 17:55    [W:0.030 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site