Messages in this thread | | | Date | Wed, 16 Feb 2011 16:11:35 +0100 | From | Clemens Ladisch <> | Subject | Re: [lm-sensors] [PATCH 3/3] hwmon: (jc42) do not allow writing to locked registers |
| |
Guenter Roeck wrote: > On Wed, Feb 16, 2011 at 08:02:38AM -0500, Clemens Ladisch wrote: > > + readonly = config & JC42_CFG_TCRIT_LOCK; > > You are assigning a non-bool to a bool. I can see that recent C compilers > do the right thing, but I am not sure if that is always the case. > So I would prefer > readonly = !!(config & JC42_CFG_TCRIT_LOCK)); > > Same for the assignments below. I can make that change if you are ok with it.
I cannot imagine how a compiler could get this wrong even if it tried to, but if you think so, go ahead. :)
Regards, Clemens
| |