Messages in this thread | | | Date | Wed, 16 Feb 2011 10:19:05 +0800 | From | wwang <> | Subject | Re: [PATCH] staging: rts_pstor: fix sparse warning |
| |
Dear Greg:
Do you mean that exactly one modification corresponds to one patch? Such as, if I add 2 static modifier and delete one function, I should send 3 patches?
wwang
于 2011年02月16日 10:09, Greg KH 写道: > On Wed, Feb 16, 2011 at 09:43:38AM +0800, wei_wang@realsil.com.cn wrote: >> From: wwang <wei_wang@realsil.com.cn> >> >> Add static modifier before some function definitions; delete function >> named rtsx_transfer_sglist which won't be called. > Thanks for describing this better. > > And now that we can easily see that you are doing more than one thing in > this patch, please redo it, only doing one-thing-per-patch as is the way > we require patches to be. > > Care to resend this as a series of patches? > > thanks, > > greg k-h
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |