lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 064/176] [SCSI] libsas: fix runaway error handler problem
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: James Bottomley <James.Bottomley@suse.de>

    commit 9ee91f7fb550a4c82f82d9818e42493484c754af upstream.

    libsas makes use of scsi_schedule_eh() but forgets to clear the
    host_eh_scheduled flag in its error handling routine. Because of this,
    the error handler thread never gets to sleep; it's constantly awake and
    trying to run the error routine leading to console spew and inability to
    run anything else (at least on a UP system). The fix is to clear the
    flag as we splice the work queue.

    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/libsas/sas_scsi_host.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/scsi/libsas/sas_scsi_host.c
    +++ b/drivers/scsi/libsas/sas_scsi_host.c
    @@ -649,6 +649,7 @@ void sas_scsi_recover_host(struct Scsi_H

    spin_lock_irqsave(shost->host_lock, flags);
    list_splice_init(&shost->eh_cmd_q, &eh_work_q);
    + shost->host_eh_scheduled = 0;
    spin_unlock_irqrestore(shost->host_lock, flags);

    SAS_DPRINTK("Enter %s\n", __func__);



    \
     
     \ /
      Last update: 2011-02-16 02:15    [W:0.018 / U:1.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site