Messages in this thread | | | Date | Tue, 15 Feb 2011 15:02:18 -0800 | From | Stephen Hemminger <> | Subject | Re: [PATCH] core: dev: don't call BUG() on bad input |
| |
On Mon, 14 Feb 2011 13:56:06 +0300 Vasiliy Kulikov <segoon@openwall.com> wrote:
> alloc_netdev() may be called with too long name (more that IFNAMSIZ bytes). > Currently this leads to BUG(). Other insane inputs (bad txqs, rxqs) and > even OOM don't lead to BUG(). Made alloc_netdev() return NULL, like on > other errors.
The only way alloc_netdev could be called with a name too long was if some driver was incorrectly written. It is not something that can be exercised by user space.
Please leave the BUG() so the driver will show up in kernel oops logs etc.
| |