lkml.org 
[lkml]   [2011]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically
On Tue, Feb 15, 2011 at 04:59:28PM +0000, Hank Janssen wrote:
>
>
> > -----Original Message-----
> > From: KY Srinivasan
> > Sent: Tuesday, February 15, 2011 8:54 AM
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@suse.de]
> > > Sent: Tuesday, February 15, 2011 11:00 AM
> > > To: KY Srinivasan
> > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> > > virtualization@lists.osdl.org; Haiyang Zhang; Hank Janssen
> > > Subject: Re: [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically
> > >
>
> > > And why are you still printing this out for the whole world to see?
> > Greg, this patch addressed a specific comment with regards dynamically
> > allocate the irq.
> > Hank is working on a patch to address the various DPRINTS in the code.
>
> Before the end of the week I will submit two patches for this;
>
> Remove DPRINT and change it to printk

No, use dev_dbg() and friends instead of "raw" printk() calls.

> Remove excessive printouts on startup of vmbus

That would be nice to see. There should be almost nothing outputed by
these drivers on "normal" operation.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-02-15 18:29    [W:0.067 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site