Messages in this thread | | | From | Peter Korsgaard <> | Subject | Re: [PATCH] mcp23s08: support mcp23s17 variant | Date | Tue, 15 Feb 2011 13:47:04 +0100 |
| |
>>>>> "Grant" == Grant Likely <grant.likely@secretlab.ca> writes:
Hi,
>> We could. I didn't do it because the 8bit and 16bit cases are very >> similar, and checking a simple integer is presumably a lot faster than >> the spi access - But I can rework the patch if you insists.
Grant> I won't insist, but it really does look like something that should Grant> have separate accessors from a code maintenance perspective.
Ok, I've just respun the patch with seperate accessors.
>> I wouldn't call it unrelated. It's to ensure it still lines up after the >> s/u8/unsigned/.
Grant> Sorry, you're right. I missed the s/u8/unsigned/ change. I don't Grant> have any problem with whitespace changes in a hunk that is also Grant> getting a real change.
Ok, good.
-- Bye, Peter Korsgaard
| |