lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/26] x86-64, NUMA: Unify the rest of memblk registration
Hello,

On Sat, Feb 12, 2011 at 04:45:27PM -0800, Yinghai Lu wrote:
> please don't put setup_node_bootmem calling into numa_register_memblks()
> that is not related.
>
> put the calling in initmem_init() directly is more reasonable.

No, I don't think so. If you don't like the function name, let's
change the name. I think it's better to put all registrations there.
Later in the series but function is changed to deal with struct
numa_meminfo anyway so maybe it's better to rename it to
numa_register_meminfo().

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-02-14 12:35    [from the cache]
©2003-2011 Jasper Spaans