Messages in this thread | | | Date | Mon, 14 Feb 2011 11:33:29 -0800 | Subject | Re: [PATCH v2] core: dev: don't call BUG() on bad input | From | Tom Herbert <> |
| |
On Mon, Feb 14, 2011 at 11:25 AM, David Miller <davem@davemloft.net> wrote: > From: Vasiliy Kulikov <segoon@openwall.com> > Date: Mon, 14 Feb 2011 18:23:10 +0300 > >> On Mon, Feb 14, 2011 at 17:16 +0200, Alexey Dobriyan wrote: >>> Netdevice name isn't some random junk you get from userspace, so BUG is fine. >> >> It IS for bluetooth, see net/bluetooth/bnep/core.c: bnep_add_connection() and >> net/bluetooth/bnep/sock.c: bnep_sock_ioctl(). > > If bluetooth wants to allow something so foolish, then it's bluetooth's > responsibility to sanity check the arguments before blinding passing > them into kernel APIs which expect sane inputs. > > I'm not applying this. >
Changing to BUG_ON(txqs < 1) and BUG_ON(rxqs < 1) does make sense I think.
Tom
| |