Messages in this thread Patch in this message | | | From | Hank Janssen <> | Subject | [PATCH] Staging: hv: Use list_entry for msg_info and remove associated comment | Date | Mon, 14 Feb 2011 10:35:37 -0800 |
| |
Change code to use list_entry api. And removed comment suggesting that change.
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com> Signed-off-by: K.Y. Srinivasan <kys@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
--- drivers/staging/hv/channel_mgmt.c | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/hv/channel_mgmt.c b/drivers/staging/hv/channel_mgmt.c index a9c9d49..6c497e9 100644 --- a/drivers/staging/hv/channel_mgmt.c +++ b/drivers/staging/hv/channel_mgmt.c @@ -580,8 +580,9 @@ static void vmbus_onopen_result(struct vmbus_channel_message_header *hdr) spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_for_each(curr, &vmbus_connection.chn_msg_list) { -/* FIXME: this should probably use list_entry() instead */ - msginfo = (struct vmbus_channel_msginfo *)curr; + msginfo = list_entry(curr, struct vmbus_channel_msginfo, + msglistentry); + requestheader = (struct vmbus_channel_message_header *)msginfo->msg; @@ -628,8 +629,8 @@ static void vmbus_ongpadl_created(struct vmbus_channel_message_header *hdr) spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_for_each(curr, &vmbus_connection.chn_msg_list) { -/* FIXME: this should probably use list_entry() instead */ - msginfo = (struct vmbus_channel_msginfo *)curr; + msginfo = list_entry(curr, struct vmbus_channel_msginfo, + msglistentry); requestheader = (struct vmbus_channel_message_header *)msginfo->msg; @@ -676,8 +677,8 @@ static void vmbus_ongpadl_torndown( spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_for_each(curr, &vmbus_connection.chn_msg_list) { -/* FIXME: this should probably use list_entry() instead */ - msginfo = (struct vmbus_channel_msginfo *)curr; + msginfo = list_entry(curr, struct vmbus_channel_msginfo, + msglistentry); requestheader = (struct vmbus_channel_message_header *)msginfo->msg; @@ -718,8 +719,8 @@ static void vmbus_onversion_response( spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_for_each(curr, &vmbus_connection.chn_msg_list) { -/* FIXME: this should probably use list_entry() instead */ - msginfo = (struct vmbus_channel_msginfo *)curr; + msginfo = list_entry(curr, struct vmbus_channel_msginfo, + msglistentry); requestheader = (struct vmbus_channel_message_header *)msginfo->msg; -- 1.6.0.2
| |