lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 15/26] x86-64, NUMA: Unify the rest of memblk registration
    From
    On Mon, Feb 14, 2011 at 3:32 AM, Tejun Heo <tj@kernel.org> wrote:
    > Hello,
    >
    > On Sat, Feb 12, 2011 at 04:45:27PM -0800, Yinghai Lu wrote:
    >> please don't put setup_node_bootmem calling into numa_register_memblks()
    >> that is not related.
    >>
    >> put the calling in initmem_init() directly is more reasonable.
    >
    > No, I don't think so.  If you don't like the function name, let's
    > change the name.  I think it's better to put all registrations there.
    > Later in the series but function is changed to deal with struct
    > numa_meminfo anyway so maybe it's better to rename it to
    > numa_register_meminfo().

    No, I don't like ***_register_*** take care of calling setup_bootmem.

    Yinghai
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-14 17:11    [W:0.020 / U:91.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site