Messages in this thread | | | Date | Mon, 14 Feb 2011 16:41:46 +0800 | Subject | Re: [Security] [PATCH] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1 | From | Eugene Teo <> |
| |
On Thu, Feb 10, 2011 at 10:25 PM, Dan Rosenberg <drosenberg@vsecurity.com> wrote: > The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to > xfs_fs_geometry() with a version number of 3. This code path does not > fill in the logsunit member of the passed xfs_fsop_geom_t, leading to > the leaking of four bytes of uninitialized stack data to potentially > unprivileged callers. Since all other members are filled in all code > paths and there are no padding bytes in this structure, it's safe to > avoid an expensive memset() in favor of just clearing this one field. > > Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
There are three callers to xfs_fs_geometry() with version number 3 and 4. I don't see any for version number 2, so this looks fine.
Reviewed-by: Eugene Teo <eugeneteo@kernel.org>
Thanks, Eugene -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |