lkml.org 
[lkml]   [2011]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] dlm fix for 2.6.38
On Sat, Feb 12, 2011 at 04:51:00PM +0100, Tejun Heo wrote:
> On Sat, Feb 12, 2011 at 03:44:35PM +0000, Steven Whitehouse wrote:
> > What is the issue here? If there is a problem with the workqueues then
> > we should ask Tejun about it,
>
> Yeah, what kind of problem was it? There's only one work per
> connection so reordering is not a problem. All the workqueue
> operations use proper locking, so the conversion seemed safe to me.
> What am I missing?

find_lkb seems to be getting an actual, but wrong lkid, so it's returning
the wrong lkb in the receive routines. It happens fairly quickly with
multiple wq threads, but not at all with single. One suspect I'm going to
look at are the ls_stub and fields in the lockspace struct. I'm not
convinced extra send/recv threads give us that much benefit in practice,
so it's not my top priority at the moment.

Dave



\
 
 \ /
  Last update: 2011-02-14 16:41    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean